MetaDataAPI V2 #266
Merged
MetaDataAPI V2 #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update `DynamicTypeBuilder` - update `PropertyInfo`
- update `Metadata()` - remove logic for adding providers
- firts implementation of `AttributesProvider` - add `Erc721AttributeAttribute` - remove abstract `DescriptionSource` from `PoolInfo` (use `this`) - bugfix on PoolInfo object created
- add more providers
Lomet
reviewed
Jun 18, 2024
- write `RefundProvider`
- process IsFullyWithdrawn and IsFullyRefunded cases for GetDescription - update constructors for each provider
- use `IServiceProvider` - use ITlyContext to create short url
- update code of `LambdaRequest`
- add chain not supported response
|
Let's close issues here: https://github.com/ArdenHide/NethereumGenerator/issues Then we can update our package https://github.com/The-Poolz/poolz.finance.csharp.contracts using the newest version of "ArdenHide/NethereumGenerator" It's need to possible create service which can use P.S. Right now it is impossible to create a "correct", testable class. It is possible to use the DI pattern by passing P.S.S. The ideal result is that there is no need to create a wrapper class, and we can directly use |
|
Create saved lambda requests with folow format: Example of file name: {
"Description": "Write here what is expected for this request",
"queryStringParameters": {
"poolId": 0,
"chainId": 97
}
} |
- fix second parameter for LambdaHandler
- add some saved requests
- rename `private static` member in `DefaultServiceProvider` - use `GetRequiredService` instead of `GetService` and throwing custom exception - use 1.0.4 version of `poolz.finance.csharp.contracts` package
- write `LockDealNftServiceExtensions` - register `ILockDealNFTService` service in `AbstractProvider` - typo for required services in `AbstractProvider` - remove `FetchPoolInfo` from `AbstractProvider` - update `CollateralProvider` using new extensions method - register `ILockDealNFTService` service in `LambdaFunction`
- add new extension method `IsPoolIdInSupplyRange` for `ILockDealNFTService` - beautify error message for `ChainNotSupportedResponse` - create `PoolIdNotInSupplyRangeResponse`
Lomet
reviewed
Jun 26, 2024
* - write `DateTimeExtensionsTests` - save not-working `LockDealNftServiceExtensionsTests` * - tests for `FetchPoolInfo` methods from `LockDealNftServiceExtensions` * - bugfix for `LambdaRequestValidator` - write tests for `LambdaRequestValidator` * - write tests for `LambdaRequest` * - fix `IsPoolIdInSupplyRange` tests * - code cleanup - enhancement code for tests - add `Erc20Provider` tests - add `Erc20Token` tests
* - write `DateTimeExtensionsTests` - save not-working `LockDealNftServiceExtensionsTests` * - tests for `FetchPoolInfo` methods from `LockDealNftServiceExtensions` * - bugfix for `LambdaRequestValidator` - write tests for `LambdaRequestValidator` * - write tests for `LambdaRequest` * - fix `IsPoolIdInSupplyRange` tests * - code cleanup - enhancement code for tests - add `Erc20Provider` tests - add `Erc20Token` tests * - remove CW of metadata * - add `DbChainManager` - use `DbChainManager` as default `IChainManager` * - refactor `DbChainManager` - remove `LocalChainManager` * - use prod DB * Update coverage-report.yml * Update coverage-report.yml
|
New format of description: Hash format: |
* - update `GetImage()` - use 1.0.3 version of `TLY.ShortUrl` package * Update .gitignore * - update .csproj * - cleanup * - use ternary operator
DiagramsDiagrams summary
|
SummarySummary
CoverageMetaDataAPI - 25.3%
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.